Skip to content

Convert service info functions to pybind11#694

Merged
cottsay merged 2 commits intomasterfrom
cottsay/pybind11_service_info
Mar 5, 2021
Merged

Convert service info functions to pybind11#694
cottsay merged 2 commits intomasterfrom
cottsay/pybind11_service_info

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Mar 4, 2021

Part of #665

Converts:

  • rclpy_service_info_get_sequence_number
  • rclpy_service_info_get_source_timestamp
  • rclpy_service_info_get_received_timestamp

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay requested a review from sloretz March 4, 2021 20:06
@cottsay cottsay self-assigned this Mar 4, 2021
@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Mar 4, 2021

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@cottsay cottsay mentioned this pull request Mar 4, 2021
34 tasks
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay requested a review from sloretz March 4, 2021 21:24
Copy link
Copy Markdown
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI!

@cottsay cottsay merged commit ccc83ac into master Mar 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/pybind11_service_info branch March 5, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants