Skip to content

Convert timer functions to pybind11#693

Merged
sloretz merged 1 commit intomasterfrom
pybind11_timers
Mar 8, 2021
Merged

Convert timer functions to pybind11#693
sloretz merged 1 commit intomasterfrom
pybind11_timers

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Mar 3, 2021

part of #665

Converts:

  • rclpy_reset_timer
  • rclpy_call_timer
  • rclpy_change_timer_period
  • rclpy_is_timer_ready
  • rclpy_cancel_timer
  • rclpy_is_timer_canceled
  • rclpy_time_until_next_call
  • rclpy_time_since_last_call
  • rclpy_get_timer_period
  • rclpy_create_timer

@sloretz sloretz requested a review from cottsay March 3, 2021 19:26
@sloretz sloretz self-assigned this Mar 3, 2021
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 3, 2021

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status - I think there's currently a CI issue with Windows, so this one might fail and need to be rerun

@sloretz sloretz mentioned this pull request Mar 3, 2021
Closed
34 tasks
cottsay
cottsay approved these changes Mar 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question, but otherwise LGTM.

@sloretz
Convert timer functions to pybind11
2945233 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 6, 2021

CI after rebasing to fix merge conflict (build: --packages-up-to rclpy test: --packges-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 8, 2021

CI with hopefully no typo's in the args (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 062cac3 into master Mar 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the pybind11_timers branch March 8, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cottsay cottsay cottsay approved these changes

Assignees

@sloretz sloretz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sloretz @cottsay