Convert guard condition functions to pybind11#692
Merged
Conversation
34 tasks
Contributor
Author
|
CI (build:
|
cottsay
approved these changes
Mar 4, 2021
rclpy_create_guard_condition rclpy_trigger_guard_condition Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
437e4e8 to
254103e
Compare
Contributor
Author
|
Rebased - no changes. Running full CI since windows had an issue. CI (build:
|
Contributor
Author
|
Merging since CI is green and the rebase fixed conflicts without changing any logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #665
This converts a couple guard condition functions to pybind11.