Don't call destroy_node while spinning#674
Merged
clalancette merged 1 commit intomasterfrom Feb 8, 2021
Merged
Conversation
This causes a segfault under CycloneDDS, and I don't see an easy way to prevent it from happening. Until we get to the bottom of that, just defer the call to destroy_node until after we know the spin thread has finished. Signed-off-by: Scott K Logan <logans@cottsay.net>
Contributor
|
Windows CI failed to install Qt :( - edit: which was probably fixed by ros2/ci#540 |
Contributor
|
Windows rebuild: |
Member
Author
|
Thanks, @sloretz. Looks like the rebuild came back green. |
clalancette
approved these changes
Feb 8, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes a segfault under CycloneDDS, and I don't see an easy way to prevent it from happening. Until we get to the bottom of that, just defer the call to destroy_node until after we know the spin thread has finished.
#663 tracks the issue that this change avoids.