Skip to content

Use pybind11 for _rclpy_handle#668

Merged
sloretz merged 7 commits intomasterfrom
pybind11_rclpy_handle
Feb 26, 2021
Merged

Use pybind11 for _rclpy_handle#668
sloretz merged 7 commits intomasterfrom
pybind11_rclpy_handle

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Jan 21, 2021

Part of #665
Requires #667

This uses Pybind11 for the _rclpy_handle modules. It also removes a redundant API rclpy_handle_get_name() which already existed as rclpy_pycapsule_name().

@sloretz sloretz self-assigned this Jan 21, 2021
@sloretz sloretz mentioned this pull request Jan 21, 2021
Closed
34 tasks
@sloretz sloretz force-pushed the add_pybind11_dependency branch from a11af4b to 850e84b Compare January 29, 2021 01:28
@sloretz sloretz force-pushed the add_pybind11_dependency branch 2 times, most recently from c04dc58 to 674b02c Compare February 12, 2021 17:06
@delete-merged-branch delete-merged-branch bot deleted the branch master February 12, 2021 17:07
@sloretz sloretz changed the base branch from add_pybind11_dependency to master February 12, 2021 17:27
@sloretz sloretz force-pushed the pybind11_rclpy_handle branch from 5e3d7dc to a2e174b Compare February 12, 2021 17:27
@sloretz sloretz marked this pull request as ready for review February 12, 2021 17:27
cottsay
cottsay approved these changes Feb 19, 2021
View reviewed changes
@sloretz
_rclpy_handle.c -> .cpp
af71896 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
_rclpy_handle.c -> .cpp in CMake + no rcutils dep
07a4e89 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Use Pybind11 for Handle
dacd7bf 
Also removes redunant API rclpy_handle_get_name() and
replaced it with an existing duplicate API rclpy_pycapsule_name().

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Do define Py_DEBUG on Windows
8d80665 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Remove redundant Python.h include
c898f46 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
static_assert that size_t can hold void *
1910a61 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz force-pushed the pybind11_rclpy_handle branch from a2e174b to 1910a61 Compare February 26, 2021 00:56
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Feb 26, 2021

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
static_assert needs a message
06344d3 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Feb 26, 2021

CI again with osx warning fixed:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 3e030c0 into master Feb 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the pybind11_rclpy_handle branch February 26, 2021 18:28
@nuclearsandwich nuclearsandwich mentioned this pull request Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cottsay cottsay cottsay approved these changes

Assignees

@sloretz sloretz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sloretz @cottsay