Skip to content

Use Pybind11 to generate _rclpy_logging#659

Merged
sloretz merged 5 commits intomasterfrom
prototype_pybind11_logging
Feb 26, 2021
Merged

Use Pybind11 to generate _rclpy_logging#659
sloretz merged 5 commits intomasterfrom
prototype_pybind11_logging

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Jan 13, 2021 •
edited
Loading

This is a prototype PR meant to be used for an apples-to-apples comparison with #656.

Updated to convert _rclpy_logging to use pybind11, part of #665

@azeey @IanTheEngineer @cottsay FYI

@sloretz sloretz self-assigned this Jan 13, 2021
This was referenced Jan 13, 2021
Closed
Closed
@sloretz sloretz changed the title Make _rclpy_logging use Pybind11 Use Pybind11 to generate _rclpy_logging Jan 14, 2021
@sloretz sloretz force-pushed the prototype_pybind11_logging branch from 361508f to 441ed6f Compare January 21, 2021 22:02
@sloretz sloretz changed the base branch from master to add_pybind11_dependency January 21, 2021 22:03
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Jan 21, 2021

Rebased on #667

@sloretz sloretz mentioned this pull request Jan 21, 2021
Closed
34 tasks
@sloretz sloretz force-pushed the add_pybind11_dependency branch from a11af4b to 850e84b Compare January 29, 2021 01:28
@sloretz sloretz force-pushed the add_pybind11_dependency branch 2 times, most recently from c04dc58 to 674b02c Compare February 12, 2021 17:06
@delete-merged-branch delete-merged-branch bot deleted the branch master February 12, 2021 17:07
@sloretz sloretz changed the base branch from add_pybind11_dependency to master February 12, 2021 17:29
@sloretz sloretz force-pushed the prototype_pybind11_logging branch from 441ed6f to d7a7bc4 Compare February 12, 2021 17:29
@sloretz sloretz marked this pull request as ready for review February 12, 2021 17:29
cottsay
cottsay reviewed Feb 19, 2021
View reviewed changes
@sloretz
Move _rlcpy_logging.c -> _rclpy_logging.cpp
6b6a72a 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
_rclpy_logging.c -> .cpp in CMake
73a1f70 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Use Pybind11 for _rclpy_logging
3994442 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Do define Py_DEBUG on Windows
28edb2f 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Remove redundant Python.h include
80cafe0 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz force-pushed the prototype_pybind11_logging branch from d7a7bc4 to 80cafe0 Compare February 26, 2021 01:14
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Feb 26, 2021

Rebased + two commits related to #681

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 240c15d into master Feb 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the prototype_pybind11_logging branch February 26, 2021 16:50
@nuclearsandwich nuclearsandwich mentioned this pull request Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cottsay cottsay cottsay approved these changes

Assignees

@sloretz sloretz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sloretz @cottsay