Use Pybind11's CMake functions for pycapsule lib#651
Closed
Conversation
This is a small check to see if Pybind11's CMake functions work on all platforms. It works fine locally on Linux using CMAKE_BUILD_TYPE=Debug. Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
CI:
|
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
Windows with eeb8439 |
Contributor
Author
|
Think I learned all I wanted to from this PR. Closing and following up with #652 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small check to see if Pybind11's CMake function works on all
platforms. It works fine locally on
LinuxUbuntu Focal usingCMAKE_BUILD_TYPE=Debug.@cottsay @IanTheEngineer FYI