Merged
Conversation
Member
Author
|
Testing
|
sloretz
reviewed
Apr 11, 2019
* Renamed functions for consistency with others in rclpy_common. * Changed signature of conversion function to return a PyObject pointer. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
06fa16f to
ae65143
Compare
sloretz
reviewed
Apr 12, 2019
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
sloretz
approved these changes
Apr 12, 2019
dirk-thomas
reviewed
Apr 12, 2019
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
Apr 12, 2019
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a prerequisite, I've moved the names and types functions to
rclpy_commonfor reuse in the rclpy action C extension.Connects to ros2/ros2cli#202