Skip to content

Adds a test for invalid string checks on publishing#256

Merged
hidmic merged 2 commits intomasterfrom
hidmic/improve-string-handling
Jan 8, 2019
Merged

Adds a test for invalid string checks on publishing#256
hidmic merged 2 commits intomasterfrom
hidmic/improve-string-handling

Conversation

@hidmic
Copy link
Copy Markdown
Contributor

@hidmic hidmic commented Jan 7, 2019

This pull request validates that only ASCII strings are published on string fields.

Connected to ros2/rosidl_python#26.

@hidmic hidmic requested a review from dirk-thomas January 7, 2019 20:52
@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Jan 7, 2019
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with passing CI.

@hidmic
Copy link
Copy Markdown
Contributor Author

hidmic commented Jan 8, 2019

Looks like Windows didn't like the turtle emoji for a unicode character.

@hidmic
Copy link
Copy Markdown
Contributor Author

hidmic commented Jan 8, 2019

Copied from ros2/rosidl_python#26 (comment):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Copy Markdown
Contributor Author

hidmic commented Jan 8, 2019

We're good to go!

@hidmic hidmic merged commit 37487d7 into master Jan 8, 2019
@tfoote tfoote removed the in progress Actively being worked on (Kanban column) label Jan 8, 2019
@dirk-thomas dirk-thomas deleted the hidmic/improve-string-handling branch April 4, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants