add spinning state for the Executor classes. (backport #1510)#1577
Closed
mergify[bot] wants to merge 1 commit intohumblefrom
Closed
add spinning state for the Executor classes. (backport #1510)#1577mergify[bot] wants to merge 1 commit intohumblefrom
mergify[bot] wants to merge 1 commit intohumblefrom
Conversation
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> (cherry picked from commit cf9240a) # Conflicts: # rclpy/rclpy/executors.py
Contributor
Author
|
Cherry-pick of cf9240a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
base code is different from mainline rolling, i will keep this open if someone is willing to resolve the backport conflicts.
Contributor
|
Discussed in Waffle. We're closing this. If someone wants to handle the review and downstream issues we can reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #1477 (review)
Is this user-facing behavior change?
Possibly yes, it explicitly throws the exception on the 2nd spin call if the executor is already spinning.
Did you use Generative AI?
No
Additional Information
This is an automatic backport of pull request #1510 done by [Mergify](https://mergify.com).