EventsExecutor: Handle async callbacks for services and subscriptions (backport #1478)#1513
Closed
mergify[bot] wants to merge 1 commit intojazzyfrom
Closed
EventsExecutor: Handle async callbacks for services and subscriptions (backport #1478)#1513mergify[bot] wants to merge 1 commit intojazzyfrom
mergify[bot] wants to merge 1 commit intojazzyfrom
Conversation
Contributor
Author
|
Cherry-pick of b99fc95 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EventsExecutor was not properly handling async callbacks for services and subscriptions.
Fixes #1473
Is this user-facing behavior change?
No workflow that previously worked with this executor should be impacted at all.
Did you use Generative AI?
F no.
Additional Information
Handling of async callbacks is arguably still not completely correct, as with SingleThreadedExecutor a ReentrantCallbackGroup must be used to enable the executor to do anything else while an async callback is awaiting something, and EventsExecutor ignores all callback groups. However this is still preferable to the previous behavior of exploding with a TypeError, and it sounds like from discussion on the issue that we aren't sure the SingleThreadedExecutor behavior is desirable going forward either.
This is an automatic backport of pull request #1478 done by Mergify.