Skip to content

reenable 100Hz timer test on windows#150

Merged
mikaelarguedas merged 1 commit intomasterfrom
reenable_100hz_test
Nov 17, 2017
Merged

reenable 100Hz timer test on windows#150
mikaelarguedas merged 1 commit intomasterfrom
reenable_100hz_test

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas commented Nov 17, 2017

now that we have better time resolution on windows these tests can be restored.

Unfortunately the 1kHz timer tests still fail and have to stay disabled.

  • Windows (rclpy tests ranusing --retest-until-fail 50) Build Status

@mikaelarguedas mikaelarguedas self-assigned this Nov 17, 2017
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 17, 2017
@serge-nikulin
Copy link
Copy Markdown

serge-nikulin commented Nov 17, 2017

Unfortunately the 1kHz timer tests still fail and have to stay disabled.

Have you enabled 1KHz switching in Windows from the default 15ms or so?
AFAIK, MS has introduced this feature for gamers and it might help you.

@mikaelarguedas
Copy link
Copy Markdown
Member Author

mikaelarguedas commented Nov 17, 2017

@serge-nikulin Thanks for the tip,
I don't think we changed anything explicitly. Though if the default resolution is 15.6ms I would expect our 100Hz tests to fail, at least sporadically. I'll merge this for now and post an update here when I find time to explore that lead.

@mikaelarguedas mikaelarguedas merged commit 73e5137 into master Nov 17, 2017
@mikaelarguedas mikaelarguedas deleted the reenable_100hz_test branch November 17, 2017 18:47
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Nov 17, 2017
@serge-nikulin
Copy link
Copy Markdown

serge-nikulin commented Nov 17, 2017

See https://msdn.microsoft.com/en-us/library/windows/desktop/dd757624(v=vs.85).aspx.
Call timeBeginPeriod at the startup time and don't bother to call timeEndPeriod at all.
A lot of airport security equipment around the world works in this mode for many years, non-stop, 24/365 :)

@mikaelarguedas
Copy link
Copy Markdown
Member Author

mikaelarguedas commented Nov 17, 2017

Good to know, thanks for the pointer

@mikaelarguedas mikaelarguedas mentioned this pull request Nov 21, 2017
Closed
YuanYuYuan pushed a commit to YuanYuYuan/rclpy that referenced this pull request Nov 12, 2025
@Carter12s
Merge pull request ros2#150 from Carter12s/codegen-fixed-arrays
599332b 
Support for Fixed Sized Arrays
@traversaro traversaro mentioned this pull request Dec 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloretz sloretz sloretz approved these changes

Assignees

@mikaelarguedas mikaelarguedas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikaelarguedas @serge-nikulin @sloretz