Add in the ability to start timers paused.#1138
Merged
clalancette merged 3 commits intorollingfrom Jul 5, 2023
Merged
Conversation
This was possible in the past by creating a timer and then immediately canceling it. But that could lead to a potential race where the timer fired once before it was canceled. By allowing for the user to create it paused, we avoid that race. This is the rclpy version of ros2/rclcpp#2005 Signed-off-by: Chris Lalancette <clalancette@gmail.com>
EsipovPA
reviewed
Jul 3, 2023
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
fujitatomoya
approved these changes
Jul 5, 2023
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm 👍
maybe we could add doc section that says timer with autostart = false can be started with calling reset method.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
Author
Excellent point. I've added documentation in fa71994. |
Contributor
Author
|
CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was possible in the past by creating a timer
and then immediately canceling it. But that could lead to a potential race where the timer fired once before it was canceled. By allowing for the user
to create it paused, we avoid that race.
This is the rclpy version of ros2/rclcpp#2005
@Voldivh @fujitatomoya FYI. This fixes #1137