Skip to content

Decouple rosout publisher init from node init.#1121

Merged
fujitatomoya merged 5 commits intorollingfrom
fujitatomoya/bugfix-20230427-rclcpp-issue-2147
Sep 22, 2023
Merged

Decouple rosout publisher init from node init.#1121
fujitatomoya merged 5 commits intorollingfrom
fujitatomoya/bugfix-20230427-rclcpp-issue-2147

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Apr 27, 2023

@fujitatomoya fujitatomoya mentioned this pull request Apr 27, 2023
Merged
fujitatomoya
fujitatomoya commented Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this depends on ros2/rcl#1065

iuhilnehc-ynos
iuhilnehc-ynos reviewed Jun 16, 2023
View reviewed changes
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 16, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/bugfix-20230427-rclcpp-issue-2147 branch from 3769bca to 0e2fa65 Compare June 19, 2023 18:19
@fujitatomoya
Decouple rosout publisher init from node init.
b7b549d 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
add file and line for warning message.
bdc05ef 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
address uncrustify warning.
942f9a4 
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/bugfix-20230427-rclcpp-issue-2147 branch from 0e2fa65 to 942f9a4 Compare September 11, 2023 20:37
@fujitatomoya
Decouple rosout publisher fini from node fini.
7a913a8 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Sep 11, 2023
View reviewed changes
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 19, 2023

@iuhilnehc-ynos requesting another review on this.

iuhilnehc-ynos
iuhilnehc-ynos reviewed Sep 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments

@iuhilnehc-ynos iuhilnehc-ynos mentioned this pull request Sep 20, 2023
Merged
@fujitatomoya
address review comments.
5e97177 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/bugfix-20230427-rclcpp-issue-2147 branch from dda14a1 to 5e97177 Compare September 20, 2023 19:37
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 20, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 827d597 into rolling Sep 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/bugfix-20230427-rclcpp-issue-2147 branch September 22, 2023 01:44
@hwoithe hwoithe mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloretz sloretz Awaiting requested review from sloretz

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

1 more reviewer

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @iuhilnehc-ynos