Merged
Conversation
iuhilnehc-ynos
approved these changes
Mar 31, 2023
Contributor
iuhilnehc-ynos
left a comment
There was a problem hiding this comment.
LGTM, two minor suggestions though.
6 tasks
fujitatomoya
approved these changes
Apr 3, 2023
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with minor comments.
Collaborator
|
@Barry-Xu-2018 can you start CI with related to PRs? |
Contributor
Author
|
@iuhilnehc-ynos Could you help to run CI ? |
Contributor
Please rebase it first as there is |
Contributor
Author
|
@iuhilnehc-ynos Rebase was done for ros2/rcl_interfaces#154. |
Contributor
|
CI:
|
Collaborator
|
CI:
|
wjwwood
approved these changes
Apr 17, 2023
Member
wjwwood
left a comment
There was a problem hiding this comment.
Lgtm, I think we're triaging remaining PRs with ci (since things have changed a lot in the last 11days we need to double check these ones) so hopefully once I review the rclcpp one we can get this in.
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
7747a77 to
fe9760e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address ros2/ros2#1355
Depend on ros2/rcl_interfaces#154
The commit
Add the lock for get/set logger(423b471) can be reverted after ros2/rcutils#397 is implemented.