Skip to content

Add in subscription.get_publisher_count()#1089

Merged
clalancette merged 1 commit intorollingfrom
clalancette/add-get-publisher-count
Mar 2, 2023
Merged

Add in subscription.get_publisher_count()#1089
clalancette merged 1 commit intorollingfrom
clalancette/add-get-publisher-count

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

This is available in the rcl and rclcpp layers, just seems like an oversight that it wasn't available here. I'll also be using this in some upcoming work.

This is available in the rcl and rclcpp layers, just
seems like an oversight that it wasn't available here.
I'll also be using this in some upcoming work.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Copy Markdown
Contributor Author

clalancette commented Mar 1, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clalancette
Copy link
Copy Markdown
Contributor Author

CI failures on Windows are unrelated here. Going ahead and merging. Thanks for the reviews!

@clalancette clalancette merged commit 7b41b76 into rolling Mar 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the clalancette/add-get-publisher-count branch March 2, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants