Skip to content

Commit 76fd188

Browse files
committed
Remove assertions
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
1 parent 5a0f651 commit 76fd188

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

rclpy/test/benchmark/test_benchmark_guard_condition.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@ def bm():
4242
while num_calls < ONE_THOUSAND:
4343
gc.trigger()
4444
executor.spin_once(timeout_sec=0)
45-
return num_calls == ONE_THOUSAND
4645

47-
assert benchmark(bm)
46+
benchmark(bm)
4847

4948
executor.shutdown()
5049
node.destroy_guard_condition(gc)

rclpy/test/benchmark/test_benchmark_pub_sub.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,8 @@ def bm():
5353
pub.publish(EmptyMsg())
5454
while num_calls < ONE_THOUSAND:
5555
executor.spin_once(timeout_sec=0)
56-
return num_calls == ONE_THOUSAND
5756

58-
assert benchmark(bm)
57+
benchmark(bm)
5958

6059
executor.shutdown()
6160
node.destroy_publisher(pub)

rclpy/test/benchmark/test_benchmark_timer.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,8 @@ def bm():
4141
num_calls = 0
4242
while num_calls < ONE_THOUSAND:
4343
executor.spin_once(timeout_sec=0)
44-
return num_calls == ONE_THOUSAND
4544

46-
assert benchmark(bm)
45+
benchmark(bm)
4746

4847
executor.shutdown()
4948
node.destroy_timer(timer)
@@ -74,9 +73,8 @@ def bm():
7473
num_calls = 0
7574
while num_calls < ONE_THOUSAND:
7675
executor.spin_once(timeout_sec=0)
77-
return num_calls == ONE_THOUSAND
7876

79-
assert benchmark(bm)
77+
benchmark(bm)
8078

8179
executor.shutdown()
8280
node.destroy_timer(timer)

0 commit comments

Comments
 (0)