Skip to content

added throwing parameter name if parameter is not set#815

Closed
cvbn127 wants to merge 0 commit intoros2:masterfrom
cvbn127:master
Closed

added throwing parameter name if parameter is not set#815
cvbn127 wants to merge 0 commit intoros2:masterfrom
cvbn127:master

Conversation

@cvbn127
Copy link
Copy Markdown

@cvbn127 cvbn127 commented Aug 4, 2019

No description provided.

@cvbn127 cvbn127 closed this Aug 4, 2019
@cvbn127 cvbn127 reopened this Aug 4, 2019
@thomas-moulard
Copy link
Copy Markdown

thomas-moulard commented Aug 15, 2019

Gist: https://gist.githubusercontent.com/thomas-moulard/7c8c01f2e523f5eb1524e70e01dcbefd/raw/5ea686a14c47c19586039eb3874bc455c207d9d8/ros2.repos
BUILD args: --packages-up-to ros2/rclcpp
TEST args: --packages-select ros2/rclcpp
Job: ci_launcher

@thomas-moulard

This comment has been minimized.

Sign in to view
thomas-moulard
thomas-moulard approved these changes Aug 15, 2019
View reviewed changes
Copy link
Copy Markdown

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Aug 15, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich
Copy link
Copy Markdown
Member

nuclearsandwich commented Aug 15, 2019

@cvbn127 can you please address the CI failures failures linked above.

@nuclearsandwich nuclearsandwich added the in progress Actively being worked on (Kanban column) label Aug 15, 2019
@emersonknapp
Copy link
Copy Markdown
Collaborator

emersonknapp commented Aug 23, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp
Copy link
Copy Markdown
Collaborator

emersonknapp commented Aug 27, 2019

@cvbn127 looks like the only problem with the above builds is that this package is out of date wrt to the other ros2 packages. I tried this out locally, rebased to master, and everything passes. If you rebase and push, I can retrigger CI and we can get this merged.

@ivanpauno ivanpauno closed this Aug 28, 2019
@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Aug 28, 2019 •
edited
Loading

@cvbn127 Ups, I rebased and pushed the changes into your fork, but that automatically closed the PR and I can't reopen it (sorry for that). Can you reopen it?

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Aug 28, 2019

Re-triggering CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno mentioned this pull request Aug 28, 2019
Merged
@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Sep 10, 2019

Superseded by #833.
@cvbn127 again, sorry for the error while pushing in your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

+1 more reviewer

@thomas-moulard thomas-moulard thomas-moulard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

in progress Actively being worked on (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cvbn127 @thomas-moulard @ivanpauno @nuclearsandwich @emersonknapp