Skip to content

service for transition graph#555

Merged
Karsten1987 merged 3 commits intomasterfrom
lifecycle_refactor
Oct 11, 2018
Merged

service for transition graph#555
Karsten1987 merged 3 commits intomasterfrom
lifecycle_refactor

Conversation

@Karsten1987
Copy link
Copy Markdown
Contributor

fixes #550

The biggest change (this will break existing API) here is that a rcl_lifecycle_transition_key_t now is a struct has thus has label and id. This label will then be presented when calling get_available_transitions. There is a second service introduced called get_transition_graph which yields all available transitions within the state machine. This is then helpful when introspecting the state machine.

I am not feeling a hundred percent convinced that the naming here is perfect, so I'd ask for feedback between the following separation:

  • Transition: A unique transition within the state machine is labeled as i.e. configure_to_shutdown or configure_to_configuring.
  • Key: A transition key is used here to trigger the change of state, i.e. configure or shutdown and one key can be used to trigger different individual transitions. The example here could be shutdown which can be used to trigger configure_to_shutdown or inactive_to_shutdown.

Any feedback on naming here?

@Karsten1987
Copy link
Copy Markdown
Contributor Author

CI:
linux: Build Status
osx: Build Status
win: Build Status

Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Karsten1987 Karsten1987 merged commit 3353ffb into master Oct 11, 2018
@Karsten1987 Karsten1987 deleted the lifecycle_refactor branch October 11, 2018 21:04
@Karsten1987 Karsten1987 removed the in progress Actively being worked on (Kanban column) label Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rclcpp_lifecycle] introduce new service for valid transitions to call

2 participants