Merged
Conversation
This was referenced Sep 12, 2018
Contributor
Author
402b0b3 to
261f78d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #550
The biggest change (this will break existing API) here is that a
rcl_lifecycle_transition_key_tnow is a struct has thus haslabelandid. This label will then be presented when callingget_available_transitions. There is a second service introduced calledget_transition_graphwhich yields all available transitions within the state machine. This is then helpful when introspecting the state machine.I am not feeling a hundred percent convinced that the naming here is perfect, so I'd ask for feedback between the following separation:
configure_to_shutdownorconfigure_to_configuring.configureorshutdownand one key can be used to trigger different individual transitions. The example here could beshutdownwhich can be used to triggerconfigure_to_shutdownorinactive_to_shutdown.Any feedback on naming here?