Allow for implicitly convertable loggers as well (backport #2922)#2934
Closed
mergify[bot] wants to merge 1 commit intojazzyfrom
Closed
Allow for implicitly convertable loggers as well (backport #2922)#2934mergify[bot] wants to merge 1 commit intojazzyfrom
mergify[bot] wants to merge 1 commit intojazzyfrom
Conversation
* Allow for implicitly convertable loggers as well Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> * Test implicitly convertable logger Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> * This can be simplified now Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> * fixup! This can be simplified now Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> --------- Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> (cherry picked from commit e615c7c) # Conflicts: # rclcpp/include/rclcpp/logging.hpp
Contributor
Author
|
Cherry-pick of e615c7c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Collaborator
|
closing, as automatic backport is not possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This way I can inherit from
rclpp::Loggerand still pass it to the logger macros.Is this user-facing behavior change?
Backwards compatible
Did you use Generative AI?
No
Additional Information
If accepted I would like to have this backported to active distros as well.
This is an automatic backport of pull request #2922 done by Mergify.