add NO_UNDEFINED_SYMBOLS to rclcpp_components_register_node cmake macro#2746
Merged
ahcorde merged 4 commits intoros2:jazzyfrom Mar 7, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds an option
NO_UNDEFINED_SYMBOLSto therclcpp_components_register_nodecmake macro, which adds the required linker option to the (component library) target to deny undefined symbols.Undefined symbols usually produce an error if an executable is built, but due to the way the autogenerated executable generated by
rclcpp_components_register_nodeis constructed, that doesn't happen here, and the error occurs only when executing it.This change makes this a link-time error again.
This is especially intended for the workflow of migrating a ros node which was built directly as an executable before to using
rclcpp_components_register_node.By default, the option is disabled. If no adverse impact is detected, i suggest enabling it by default in a future release.
fixes #2744