backport fix events-executor warm-up bug and add unit-tests (#2591)#2628
Merged
backport fix events-executor warm-up bug and add unit-tests (#2591)#2628
Conversation
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Collaborator
Author
|
CI:
|
…bool flag to false in callback Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Collaborator
Author
|
Fixed a couple of issues. CI
|
alsora
commented
Sep 15, 2024
rclcpp/src/rclcpp/experimental/executors/events_executor/events_executor.cpp
Show resolved
Hide resolved
fujitatomoya
approved these changes
Sep 16, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
ahcorde
approved these changes
Sep 17, 2024
Contributor
|
warning on RHEL are unrelated |
|
Thanks for taking care and merging! |
Contributor
FYI @marcoag |
Contributor
|
Ok, let me check if I can include this in the current patch sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport fix events-executor warm-up bug and add unit-tests (#2591)
Replaces mergify PR with conflicts: #2625