add mutex to protect events_executor current entity collection#2187
Merged
add mutex to protect events_executor current entity collection#2187
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mutex to protect events_executor current entity collection and add unit-test.
The mutex is needed because the collection is essentially a list where
refresh_current_collection_from_callback_groupscan add/remove elements andretrieve_entitycan read/remove elements.Added a unit-test that without this PR was failing ~75% of the times and now succeeds.