Fix clock state cached time to be a copy, not a reference.#2092
Fix clock state cached time to be a copy, not a reference.#2092clalancette merged 1 commit intorollingfrom
Conversation
That is, in cache_last_msg(), we were just taking a shared_ptr reference. While this is pretty fast, it also means that any changes to that message would be reflected internally. Instead, make a new shared pointer out of that message when it comes in, which essentially causes this to be a copy. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
LGTM wit CI! |
|
CI:
|
fujitatomoya
left a comment
There was a problem hiding this comment.
@clalancette lgtm, let me try this fixes the flaky test since i can reproduce this issue my local environment. i want to make sure about this.
Yeah, that would be good to verify. It fixed it for me here, but I will note that |
|
@clalancette i tried 100 times and no failure observed on that test. thanks for the fix.
yeah, i am aware of that, i will post the issue so that we cannot miss it, lets track this with another issue. on this PR, good to go with green CI 🚀 |
Thanks for double-checking!
Sounds good. I'll open one later today. |
|
CI is green here, so merging this in. Thanks for the reviews. |
That is, in cache_last_msg(), we were just taking a shared_ptr reference. While this is pretty fast, it also means that any changes to that message would be reflected internally. Instead, make a new shared pointer out of that message when it comes in, which essentially causes this to be a copy.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This should fix #2088 . FYI @fujitatomoya and @mjcarroll .