Fix bug that a callback not reached (backport #1640)#2033
Merged
fujitatomoya merged 1 commit intohumblefrom Nov 10, 2022
Merged
Fix bug that a callback not reached (backport #1640)#2033fujitatomoya merged 1 commit intohumblefrom
fujitatomoya merged 1 commit intohumblefrom
Conversation
* Add a test case a subscriber on a new executor with a callback group triggered to receive a message Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix flaky and not to use spin_some Signed-off-by: Chen Lihui <lihui.chen@sony.com> * update comment Signed-off-by: Chen Lihui <lihui.chen@sony.com> * update for not using anti-pattern source code Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add a notify guard condition for callback group Co-authored-by: William Woodall <william@osrfoundation.org> Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Notify guard condition of Node not to be used in Executor it is only for the waitset of GraphListener Signed-off-by: Chen Lihui <lihui.chen@sony.com> * put code in the try catch Signed-off-by: Chen Lihui <lihui.chen@sony.com> * defer to create guard condition Signed-off-by: Chen Lihui <lihui.chen@sony.com> * use context directly for the create function Signed-off-by: Chen Lihui <lihui.chen@sony.com> * cpplint Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix that some case might call add_node after shutdown Signed-off-by: Chen Lihui <lihui.chen@sony.com> * nitpick and fix some potential bug Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add sanity check as some case might not create notify guard condition after shutdown Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Cleanup includes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * remove destroy method make a callback group can only create one guard condition Signed-off-by: Chen Lihui <lihui.chen@sony.com> * remove limitation that guard condition can not be re-created in callback group Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: William Woodall <william@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit d119157)
Collaborator
|
@iuhilnehc-ynos can you do another review, and run CI if you are good to go? |
iuhilnehc-ynos
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1640 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com