[Galactic backport] Do not attempt to use void allocators for memory allocation#2001
Closed
sykwer wants to merge 1 commit intoros2:galacticfrom
Closed
[Galactic backport] Do not attempt to use void allocators for memory allocation#2001sykwer wants to merge 1 commit intoros2:galacticfrom
sykwer wants to merge 1 commit intoros2:galacticfrom
Conversation
Keep a rebound allocator for byte-sized memory blocks around for publisher and subscription options. Follow-up after 1fc2d58 Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Collaborator
Contributor
|
Given that Galactic is now EOL, closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to fix the type of allocator passed to a publisher and a subscriber, otherwise, extra memory space is allocated at various parts of
rcl.For instance, a memory area of size
sizeof(rcutils_string_map_impl_t) * sizeof(MessageT)is allocated here.This bug not only causes extra memory consumption, but also causes
std::bad_allocin the publisher (and subscriber) that handles the message type when a huge message (larger than a few hundred MB) such as static size array is defined.backport #1657
Signed-off-by: Takahiro Ishikawa sykwer@gmail.com