Skip to content

wait for subscriptions on another thread#1940

Merged
fujitatomoya merged 1 commit intoros2:masterfrom
fujitatomoya:bugfix/wait_for_subscribers_on_another_thread
Jun 9, 2022
Merged

wait for subscriptions on another thread#1940
fujitatomoya merged 1 commit intoros2:masterfrom
fujitatomoya:bugfix/wait_for_subscribers_on_another_thread

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented May 23, 2022

related to ros2/rmw_fastrtps#568 (comment)

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

@fujitatomoya
wait for subscriptions on another thread.
5d3b1ab 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya requested a review from ivanpauno May 23, 2022 17:27
fujitatomoya
fujitatomoya commented May 23, 2022
View reviewed changes
@fujitatomoya fujitatomoya mentioned this pull request May 23, 2022
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented May 23, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented May 26, 2022

CI still failing with https://ci.ros2.org/job/ci_linux-aarch64/11327/testReport/

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 4, 2022

CI failure can be reproducible in my environment.
According to the error https://ci.ros2.org/job/ci_linux-aarch64/11327/testReport/, using LoanedMessage from the middle-ware leads to failure for destroying publisher handle in the implementation. (in this particular case, DDS writer)

@fujitatomoya fujitatomoya changed the title wait for subscriptions on another thread. LoanedMessage test adjustment Jun 4, 2022
fujitatomoya
fujitatomoya commented Jun 4, 2022
View reviewed changes
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 4, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 4, 2022

https://ci.ros2.org/job/ci_windows/17196/msbuild/ and https://ci.ros2.org/job/ci_windows/17196/testReport/ are unrelated.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 4, 2022

@ivanpauno can you do another review?

ivanpauno
ivanpauno approved these changes Jun 6, 2022
View reviewed changes
@fujitatomoya fujitatomoya force-pushed the bugfix/wait_for_subscribers_on_another_thread branch from 4af9a7c to 5d3b1ab Compare June 8, 2022 21:12
@fujitatomoya fujitatomoya changed the title LoanedMessage test adjustment wait for subscriptions on another thread Jun 8, 2022
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Jun 8, 2022

This does not depend on anything but just bug fix. (CI failure can be observed only if rmw implementation uses LoanedMessage.)

@fujitatomoya fujitatomoya merged commit b3f5703 into ros2:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @ivanpauno