Skip to content

Drop wrong template specialization (backport #1926)#1937

Merged
ivanpauno merged 1 commit intohumblefrom
mergify/bp/humble/pr-1926
Jun 15, 2022
Merged

Drop wrong template specialization (backport #1926)#1937
ivanpauno merged 1 commit intohumblefrom
mergify/bp/humble/pr-1926

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented May 20, 2022

This is an automatic backport of pull request #1926 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@jspricke @mergify
Drop wrong template specialization (#1926)
123b5e3 
This fails with g++ -std=gnu++20.

Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
(cherry picked from commit 02802bc)
@mergify mergify bot mentioned this pull request May 20, 2022
Merged
@fujitatomoya fujitatomoya mentioned this pull request May 20, 2022
Closed
@ivanpauno ivanpauno requested a review from audrow May 20, 2022 19:30
@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented May 20, 2022 •
edited
Loading

I'm not sure if we want to do this now, or merge it for the first patch release...

@audrow
Copy link
Copy Markdown
Member

audrow commented May 20, 2022 •
edited
Loading

Let's include this in the first patch.

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Jun 6, 2022

I think that this won't break ABI, but I'm not 100% sure.
I checked on linux, and it seems that there was not simbol for the template specialized constructor in rclcpp (it was always inlined in the code using it).
So doing this should be fine, though I'm not sure if it can break ABI in some of the other platforms.

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Jun 6, 2022

@wjwwood could you double check ABI compatibility?

@ivanpauno ivanpauno mentioned this pull request Jun 9, 2022
Closed
@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Jun 13, 2022 •
edited
Loading

I checked with the abi compliance checker, there are no warnings or errors reported.

@ivanpauno ivanpauno requested a review from clalancette June 13, 2022 20:07
audrow
audrow approved these changes Jun 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ivanpauno ivanpauno merged commit 166007d into humble Jun 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-1926 branch June 15, 2022 18:02
@Benjamin-Tan
Copy link
Copy Markdown

Benjamin-Tan commented Sep 9, 2022

Sorry if i am asking a stupid question as I am still facing this issue. May I know when will this fix be available on the release?

My ros-humble-rclcpp version is 16.0.1-2jammy.20220729.143341

@russkel
Copy link
Copy Markdown

russkel commented Nov 23, 2022

@Benjamin-Tan this patch was included in ae8b033 which was earlier this month. It should be rolling out soon. You can always pull that version down and compile yourself until they roll it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@audrow audrow audrow approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ivanpauno @audrow @Benjamin-Tan @russkel @fujitatomoya @clalancette @jspricke