Conversation
rclcpp/include/rclcpp/parameter.hpp
Outdated
There was a problem hiding this comment.
Despite C++11 supporting unions with members with non-trivial constructors (e.g. std::string), I couldn't get the union play nice with std::map because of std::pair. Any feedback will be appreciated.
|
Please make sure that the new code passes the unit tests, e.g. the code style checked by uncrustify. |
rclcpp/include/rclcpp/node.hpp
Outdated
There was a problem hiding this comment.
This method could be const. Same for the get_params.
|
The PR adds the API as well as the storage of the parameters to the node class directly. In the future a node will also have a service / topic interface to interact with them . Let me describe a few examples why I think the implementation should be separated from the node instance:
|
|
@dirk-thomas this PR does not implement the API that's exposed to developers, this just implements the internal storage for a node. This PR adds the internal structures and logic to support the public API. |
ded15cf to
b85dae9
Compare
7387479 to
97dd346
Compare
This PR adds the internal infrastructure for the parameters API.
Connects ros2/ros2#11
Connects ros2/ros2#28
@dirk-thomas @tfoote @wjwwood