[Foxy backport] wait for message (#1705)#1737
Merged
Karsten1987 merged 3 commits intofoxyfrom Aug 3, 2021
Merged
Conversation
Contributor
Author
|
* wait for message Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * move to own header file Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * linters Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * add gc for shutdown interrupt Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * mention behavior when shutdown is called Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * check gc Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
23ad5fa to
018701e
Compare
fujitatomoya
reviewed
Aug 2, 2021
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
Do we have backport for galactic?
Contributor
Author
|
The existing foxy API |
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Contributor
Author
|
fujitatomoya
reviewed
Aug 3, 2021
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
approved these changes
Aug 3, 2021
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
@Karsten1987 that was quick 😄 thanks!
Contributor
Author
|
PR job as well as Windows test failures are unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1705