Skip to content

Fix SEGV caused by order of destruction of Node sub-interfaces (backport #1469)#1736

Merged
ivanpauno merged 1 commit intofoxyfrom
mergify/bp/foxy/pr-1469
Aug 3, 2021
Merged

Fix SEGV caused by order of destruction of Node sub-interfaces (backport #1469)#1736
ivanpauno merged 1 commit intofoxyfrom
mergify/bp/foxy/pr-1469

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Aug 2, 2021

This is an automatic backport of pull request #1469 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* added tear-down of node sub-interfaces in reverse order of their creation (#1469)

Signed-off-by: Colin MacKenzie <colin@flyingeinstein.com>

* added name of service to log message for leak detection. Previously it gave no indication of what node is causing the memory leak (#1469)

Signed-off-by: Colin MacKenzie <colin@flyingeinstein.com>
(cherry picked from commit b9ffd72)
Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems ABI safe to me.

@ivanpauno
Copy link
Copy Markdown
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Copy Markdown
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Copy Markdown
Member

The pull request builder didn't run for some reason ....
@ros-pull-request-builder retest this please

Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivanpauno
Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please

1 similar comment
@ivanpauno
Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please

@ivanpauno ivanpauno merged commit 92fe787 into foxy Aug 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/foxy/pr-1469 branch August 3, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants