[galactic] Declare parameters uninitialized (#1673)#1681
Merged
jacobperron merged 1 commit intogalacticfrom May 20, 2021
Merged
[galactic] Declare parameters uninitialized (#1673)#1681jacobperron merged 1 commit intogalacticfrom
jacobperron merged 1 commit intogalacticfrom
Conversation
* Declare parameters uninitialized Fixes #1649 Allow declaring parameters without an initial value or override. This was possible prior to Galactic, but was made impossible since we started enforcing the types of parameters in Galactic. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove assertion Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Throw NoParameterOverrideProvided exception if accessed before initialized Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add test getting static parameter after it is set Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Do not throw on access of uninitialized dynamically typed parameter Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Rename exception type Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove unused exception type Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Uncrustify Signed-off-by: Jacob Perron <jacob@openrobotics.org>
6 tasks
cottsay
approved these changes
May 19, 2021
Member
cottsay
left a comment
There was a problem hiding this comment.
Looks good.
For the record: We discussed this change at the ROS 2 meeting, and decided to grant an exception to the core freeze for Galactic due in part to the limited scope of downstream usage and the return to previously established behavior that this change enables.
clalancette
approved these changes
May 20, 2021
Member
Author
|
Collaborator
|
@jacobperron its my plan to release nav2 shortly. I'm going to assume from the 2 approvals here that this is on its way so that if I merge the complementary Nav2 PR, we should be good to go? |
Member
Author
|
@SteveMacenski That's right, we should go good to go. |
Member
Author
|
macOS warnings are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1673 to Galactic.
I've released this change into Rolling and haven't noticed any regressions. The only code I found that this affects is in navigation2 and I've got a patch there: ros-navigation/navigation2#2347