content filtered topic for action_feedback and parameterevent#1592
Open
iuhilnehc-ynos wants to merge 14 commits intoros2:rollingfrom
Open
content filtered topic for action_feedback and parameterevent#1592iuhilnehc-ynos wants to merge 14 commits intoros2:rollingfrom
iuhilnehc-ynos wants to merge 14 commits intoros2:rollingfrom
Conversation
15 tasks
Collaborator
|
the same question with ros2/rcl#901 (comment) here, this PR includes #1561. |
Collaborator
Author
Yes. Due to the #1561 not merged, I think I need to do it in this way. Do you have any suggestions? |
fujitatomoya
approved these changes
Mar 24, 2021
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
overall, seems to be okay with nitpicks.
|
|
||
| /// Check if subscription instance can support content filter topic feature. | ||
| /** | ||
| * Depending on the middleware and the message type, this will return true if the middleware |
Collaborator
There was a problem hiding this comment.
oversight from internal review, is this dependent on message type?
Collaborator
Author
There was a problem hiding this comment.
Thanks for pointing it out.
rclcpp/src/rclcpp/time_source.cpp
Outdated
|
|
||
| void TimeSource::on_parameter_event(const rcl_interfaces::msg::ParameterEvent::SharedPtr event) | ||
| { | ||
| RCLCPP_DEBUG(logger_, "this node should not get others' parameter event if CFT is supported"); |
Collaborator
There was a problem hiding this comment.
if CFT is not supported, this prints every single time on parameter event happens. probably we would want to print this message if CFT is supported only?
Collaborator
Author
There was a problem hiding this comment.
OK, I'll update it.
d1d3c34 to
ba4ece3
Compare
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
to support content filter for action client feedback subscription Signed-off-by: Chen Lihui <lihui.chen@sony.com>
ba4ece3 to
50aeb0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to ros2/design#282
/parameter_eventsenhancementaction
feedbackenhancement