[foxy backport] Benchmark lifecycle features (#1462)#1471
Merged
Conversation
* Benchmark lifecycle features Signed-off-by: Stephen Brawner <brawner@gmail.com> * Cleanup Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
Foxy job, with benchmarks on and testing
|
Member
|
@ros-pull-request-builder retest this please |
cottsay
approved these changes
Nov 20, 2020
Contributor
Author
|
Windows shows some ms build warnings which are not expected with performance jobs, but they were addressed in rolling and are awaiting a backport PR of ros2/rcutils#311 |
Member
|
@ros-pull-request-builder retest this please |
Contributor
Author
|
Thanks Scott for reminding me about this. Looks like the Fpr job went through cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the lifecycle benchmarks from #1462. This should probably wait for merging until
performance_test_fixtureis released into foxy as merging this PR will break rpr jobs.Signed-off-by: Stephen Brawner brawner@gmail.com