[Dashing backport]: Fix NodeOptions copy constructor (#1376)#1466
Merged
[Dashing backport]: Fix NodeOptions copy constructor (#1376)#1466
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Member
|
This backport introduces a PR job failure that's not on the main dashing dev job. Since today is the release cutoff for Patch release 8 I am bumping this to the next patch release. |
Member
Author
Seems to be a flake. @ros-pull-request-builder retest this please |
Member
Author
|
@ros-pull-request-builder retest this please |
Member
|
@ros-pull-request-builder retest this please |
fujitatomoya
approved these changes
Dec 1, 2020
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm, test looks flaky since node graph takes time to update.
Member
|
@ros-pull-request-builder retest this please (test is actually confirming that buildfarm hooks are back online) |
wjwwood
approved these changes
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1376.