[foxy backport] Clear members for StaticExecutorEntitiesCollector to avoid shared_ptr dependency (#1303)#1407
Merged
brawner merged 1 commit intobrawner/rclcpp-backport-tests-part1from Oct 16, 2020
Conversation
… dependency (#1303) * Clear members for StaticExecutorEntitiesCollector to avoid shared_ptr dependency Signed-off-by: Chen Lihui <Lihui.Chen@sony.com> Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
I removed the minor signature change in |
Contributor
Author
|
Testing
|
Contributor
Author
|
Failure on macOS is just due to cppcheck timing out at 3 minutes, which is a rare but pre-existing issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #1303 to the main foxy unit test backport PR #1383, where it's being staged to make sure test failures are minimized before final merging onto foxy.