ComponentManager: switch off parameter services and event publisher#1333
Merged
ivanpauno merged 3 commits intoros2:masterfrom Oct 6, 2020
Merged
ComponentManager: switch off parameter services and event publisher#1333ivanpauno merged 3 commits intoros2:masterfrom
ivanpauno merged 3 commits intoros2:masterfrom
Conversation
So far, the component manager has no parameters anyway, so no need for services to configure them or topics to publish events. An attempt to limit the number of services / topics. (https://discourse.ros.org/t/ros2-default-behavior-wifi/13460/35) Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>
Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>
bfcf597 to
1704b29
Compare
Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>
772ecff to
86946d3
Compare
Member
|
I think that having an argument to enable/disable the parameter services or the parameter events might make sense too. |
wjwwood
approved these changes
Oct 5, 2020
Member
wjwwood
left a comment
There was a problem hiding this comment.
lgtm, but it would be nice to mention this in the doc block too.
Member
|
CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the component manager has no parameters anyway, so no need for
services to configure them or topics to publish events.
An attempt to limit the number of services / topics.
(https://discourse.ros.org/t/ros2-default-behavior-wifi/13460/35)
Signed-off-by: Martijn Buijs martijn.buijs@gmail.com