Skip to content

(eloquent) Add operator!= to Duration#1279

Closed
ivanpauno wants to merge 1 commit intoeloquentfrom
ivanpauno/eloquent-duration-neq
Closed

(eloquent) Add operator!= to Duration#1279
ivanpauno wants to merge 1 commit intoeloquentfrom
ivanpauno/eloquent-duration-neq

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno commented Aug 14, 2020

Backports #1236.

This is an addition, not a bug fix.
It makes sense to me to backport this for consistency. It's weird to have all comparison operators except !=.

@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Aug 14, 2020
@ivanpauno ivanpauno requested review from audrow and mjcarroll August 14, 2020 13:24
@ivanpauno ivanpauno self-assigned this Aug 14, 2020
@ivanpauno ivanpauno mentioned this pull request Aug 14, 2020
Merged
mjcarroll
mjcarroll approved these changes Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm having trouble determining what caused the build to go red.

@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented Aug 14, 2020 

06:36:27 WARNING: The converted file for the input file '/home/jenkins-agent/workspace/Epr__rclcpp__ubuntu_bionic_amd64/ws/test_results/rclcpp/Testing/20200814-1333/Test.xml' doesnt match the JUnit format.
06:36:27 WARNING: At line 2 of file:/home/jenkins-agent/workspace/Epr__rclcpp__ubuntu_bionic_amd64/generatedJUnitFiles/78066d8c-0342-4b57-8755-dce13d49c188/GoogleTest/TEST-7264dd97-ae13-4794-8c46-89af4792e5f2.xml:Premature end of file.
06:36:27 WARNING: Technical validation:Premature end of file.
06:36:27 ERROR: Premature end of file.
06:36:27 ERROR: Premature end of file.
06:36:27 ERROR: Step ‘Publish xUnit test result report’ failed: The converted file for the result file '/home/jenkins-agent/workspace/Epr__rclcpp__ubuntu_bionic_amd64/ws/test_results/rclcpp/Testing/20200814-1333/Test.xml' (during conversion process for the metric 'GoogleTest') is not valid. The report file has been skipped.

😮

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 14, 2020

@ros-pull-request-builder retest this please (using custom job config from ros-infrastructure/ros_buildfarm#828)

audrow
audrow approved these changes Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending Docs test and the build passing.

audrow
audrow approved these changes Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@audrow audrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Oops, meant to review one of the other backports.)

@ivanpauno
add operator!= for duration (#1236)
a253b0c 
Signed-off-by: Jannik Abbenseth <jannik.abbenseth@ipa.fraunhofer.de>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/eloquent-duration-neq branch from cf55061 to a253b0c Compare August 18, 2020 13:02
@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented Aug 19, 2020

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Copy Markdown
Member

jacobperron commented Aug 24, 2020

@ros-pull-request-builder retest this please (using custom job config from ros-infrastructure/ros_buildfarm#831)

@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented Oct 7, 2020

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Copy Markdown
Member Author

ivanpauno commented Jan 29, 2021

Closing as eloquent is EOL

@ivanpauno ivanpauno closed this Jan 29, 2021
@jacobperron jacobperron deleted the ivanpauno/eloquent-duration-neq branch February 1, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@audrow audrow audrow approved these changes

Assignees

@ivanpauno ivanpauno

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ivanpauno @dirk-thomas @jacobperron @mjcarroll @audrow