[backport foxy] Reorganize test directory and split CMakeLists.txt (#1173)#1262
Merged
[backport foxy] Reorganize test directory and split CMakeLists.txt (#1173)#1262
Conversation
Contributor
Author
|
Testing
|
Contributor
|
@brawner Friendly ping on this one. I think the pytest problems should be sorted now, so this should be good for another try on CI (and a rebase, it looks like). |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
f123b65 to
7bccd5d
Compare
Contributor
Author
|
Fortunately the rebase was simple since it just moves file around (and the cmakelists.txt hasn't been changed)
|
Contributor
Author
|
macOS failure seems unrelated and I've seen that test fail many times before but it doesn't show up on nightlies. Trying again
|
Contributor
Author
|
I rebuilt the same job, but without the backport branch and it had the same issue.
I believe this was a prexisting issue and unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Brawner brawner@gmail.com