Skip to content

[rclcpp lifecycle] removed rmw_implementation from package.xml#991

Merged
ahcorde merged 2 commits intomasterfrom
ahcorde/dependency/rclcpp_lifecycle_remove_rmw_implemenetation
Feb 27, 2020
Merged

[rclcpp lifecycle] removed rmw_implementation from package.xml#991
ahcorde merged 2 commits intomasterfrom
ahcorde/dependency/rclcpp_lifecycle_remove_rmw_implemenetation

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Feb 14, 2020

rmw implementation was declared as a build_depend and exec_depend but I think this is not needed anymore

@ahcorde ahcorde added the enhancement New feature or request label Feb 14, 2020
@ahcorde ahcorde requested a review from wjwwood February 14, 2020 18:17
@ahcorde ahcorde self-assigned this Feb 14, 2020
Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, check DCO though.

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde force-pushed the ahcorde/dependency/rclcpp_lifecycle_remove_rmw_implemenetation branch from 7f6e04e to e579506 Compare February 14, 2020 19:42
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Feb 14, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@dirk-thomas
Copy link
Copy Markdown
Member

Same as #990 (comment).

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Feb 17, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Feb 23, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Feb 26, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Feb 27, 2020

Unrelated tests failures. Merging

@ahcorde ahcorde merged commit 090e1cb into master Feb 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/dependency/rclcpp_lifecycle_remove_rmw_implemenetation branch February 27, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants