[rclcpp] removed ament_cmake from package.xml and CMakeLists.txt#989
Merged
[rclcpp] removed ament_cmake from package.xml and CMakeLists.txt#989
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been checking the package.xml and CMakeLists.txt.
ament_cmakeis defined as a<build_type>. In this package was defined as a<exec_depend>which I think it doesn't make any sense.should be defined here as a
<buildtool_depend>or<buildtool_export_depend>? o including one of this tag is redundant?