Skip to content

get_actual_qos should return an rclcpp::QoS rather than an rmw_qos_profile_t #859

@wjwwood

Description

@wjwwood

Introduced to the Publisher class in #667, this function really ought to return the rclcpp version of the QoS. Users can always use these methods on the rclcpp::QoS class to get the rmw profile still:

/// Return the rmw qos profile.
rmw_qos_profile_t &
get_rmw_qos_profile();
/// Return the rmw qos profile.
const rmw_qos_profile_t &
get_rmw_qos_profile() const;

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions