-
Notifications
You must be signed in to change notification settings - Fork 522
Closed
Labels
backlogenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
rcl returns the node names and their namespaces, but in rclcpp you cannot get the node namespaces, see:
rclcpp/rclcpp/src/rclcpp/node_interfaces/node_graph.cpp
Lines 133 to 143 in 3919ab1
| std::vector<std::string> | |
| NodeGraph::get_node_names() const | |
| { | |
| std::vector<std::string> nodes; | |
| auto names_and_namespaces = get_node_names_and_namespaces(); | |
| for (const auto & it : names_and_namespaces) { | |
| nodes.push_back(it.first); | |
| } | |
| return nodes; | |
| } |
There should probably be a new function that returns the nodes and their namespaces separately, and then keep the existing one for convenience but change it to automatically concatenate the name and namespace, because that's likely what you want in most cases.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
backlogenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed