Skip to content

Bind is no longer in std::__1#618

Merged
wjwwood merged 1 commit intomasterfrom
unknown repository
Jan 14, 2019
Merged

Bind is no longer in std::__1#618
wjwwood merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 11, 2019

The namespace of the __bind function in llvm is now in std and not std::__1

Signed-off-by: kuzai <kuzai@users.noreply.github.com>
@tfoote tfoote added the in review Waiting for review (Kanban column) label Jan 11, 2019
Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch works on my mac (High Sierra, Apple LLVM version 10.0.0 (clang-1000.11.45.5)).

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jan 14, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jan 14, 2019

Thanks!

@wjwwood wjwwood merged commit 1e91fac into ros2:master Jan 14, 2019
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jan 14, 2019
cho3 pushed a commit to cho3/rclcpp that referenced this pull request Jun 3, 2019
Signed-off-by: kuzai <kuzai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants