Skip to content

Allow removing a waitable#597

Merged
sloretz merged 1 commit intomasterfrom
remove_waitable
Dec 4, 2018
Merged

Allow removing a waitable#597
sloretz merged 1 commit intomasterfrom
remove_waitable

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Dec 4, 2018

Adds API to CallbackGroup and NodeWaitablesInterface to remove a waitable from a node. This will be used by an action server and action client to remove themselves when they're destroyed.

@sloretz sloretz added enhancement New feature or request in review Waiting for review (Kanban column) labels Dec 4, 2018
@sloretz sloretz requested a review from hidmic December 4, 2018 17:10
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Dec 4, 2018

@wjwwood, @hidmic noticed that the weak pointers added to a CallbackGroup never seem to be removed when they become invalid. Do you know if there is code to do that? I only see clearing of null handles in the MemoryStrategy.

rclcpp/rclcpp/include/rclcpp/strategies/allocator_memory_strategy.hpp

Line 93 in 3af8d2c

virtual void remove_null_handles(rcl_wait_set_t * wait_set)

jacobperron
jacobperron approved these changes Dec 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Dec 4, 2018

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 9c25ba9 into master Dec 4, 2018
@sloretz sloretz deleted the remove_waitable branch December 4, 2018 21:03
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Dec 4, 2018
cho3 pushed a commit to cho3/rclcpp that referenced this pull request Jun 3, 2019
@sloretz @christopherho-ApexAI
Allow removing a waitable (ros2#597)
d4f4f90
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
@Blast545
Change naming style for private functions (ros2#597)
3eda4b9 
* Add prefix "_" underscore missing in private functions

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>

* Change style for functions internal to module

Removed underscores
Added static keyword

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@jacobperron jacobperron jacobperron approved these changes

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sloretz @mjcarroll @jacobperron