fix wrong use of constructor and hanging test#596
Merged
dirk-thomas merged 2 commits intomasterfrom Nov 29, 2018
Merged
Conversation
wjwwood
approved these changes
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit: passing
rclcpp::ParameterType::PARAMETER_NOT_SETto therclcpp::ParameterValueconstructor is wrong since it interprets the parameter as an integer value. This currently results in the test to print the following error message:This happened in the Windows builds for an OpenSplice contribution: https://ci.ros2.org/job/ci_windows/5590/
Beside that error message the test still timed out.
Second commit: adds a call to
rclcpp::shutdown()in the tests tear down function.With these changes doesn't time out anymore and doesn't print any error message for invalid parameters anymore: https://ci.ros2.org/job/ci_windows/5596/