refactor init to allow for non-global init#587
Merged
Conversation
5e2d459 to
fa265f5
Compare
Signed-off-by: William Woodall <william@osrfoundation.org>
fa265f5 to
fd33795
Compare
jacobperron
previously requested changes
Nov 26, 2018
Member
jacobperron
left a comment
There was a problem hiding this comment.
Mostly nitpicks along with a few questions and bugs spotted (I think).
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
sloretz
approved these changes
Nov 30, 2018
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
* refactor init to allow for non-global init Signed-off-by: William Woodall <william@osrfoundation.org> * Update rclcpp/include/rclcpp/utilities.hpp Co-Authored-By: wjwwood <william+github@osrfoundation.org> * Update rclcpp/include/rclcpp/utilities.hpp Co-Authored-By: wjwwood <william+github@osrfoundation.org> * Update rclcpp/include/rclcpp/utilities.hpp Co-Authored-By: wjwwood <william+github@osrfoundation.org> * Update rclcpp/src/rclcpp/utilities.cpp Co-Authored-By: wjwwood <william+github@osrfoundation.org> * refactor state into context objects and fix signal handling Signed-off-by: William Woodall <william@osrfoundation.org> * avoid nullptr access in error messages Signed-off-by: William Woodall <william@osrfoundation.org> * avoid exception in publish after shutdown was called Signed-off-by: William Woodall <william@osrfoundation.org> * fix missing and unused headers Signed-off-by: William Woodall <william@osrfoundation.org> * cpplint Signed-off-by: William Woodall <william@osrfoundation.org> * fixes found during testing Signed-off-by: William Woodall <william@osrfoundation.org> * address bug found in review comment Signed-off-by: William Woodall <william@osrfoundation.org> * fixes and warnings fixed during testing Signed-off-by: William Woodall <william@osrfoundation.org> * addressing review comments Signed-off-by: William Woodall <william@osrfoundation.org> * ensure new ExecutorArgs are used everywhere
This was referenced Mar 19, 2020
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#154