Skip to content

log error message instead of throwing exception in destructor#535

Merged
Karsten1987 merged 1 commit intomasterfrom
fix_534
Aug 17, 2018
Merged

log error message instead of throwing exception in destructor#535
Karsten1987 merged 1 commit intomasterfrom
fix_534

Conversation

@Karsten1987
Copy link
Copy Markdown
Contributor

fixes #534

@Karsten1987 Karsten1987 added the in review Waiting for review (Kanban column) label Aug 17, 2018
@Karsten1987 Karsten1987 self-assigned this Aug 17, 2018
@Karsten1987 Karsten1987 merged commit 45d74ba into master Aug 17, 2018
@Karsten1987 Karsten1987 removed the in review Waiting for review (Kanban column) label Aug 17, 2018
@Karsten1987 Karsten1987 deleted the fix_534 branch August 17, 2018 17:17
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
…_QOS events (ros2#535)

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Co-authored-by: Miaofei <miaofei@amazon.com>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
ros2#535)

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not throw exceptions inside a custom deleter

2 participants