Skip to content

Fix rosidl dependencies#507

Merged
mikaelarguedas merged 2 commits intomasterfrom
remove_unused_deps
Jul 5, 2018
Merged

Fix rosidl dependencies#507
mikaelarguedas merged 2 commits intomasterfrom
remove_unused_deps

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas commented Jul 3, 2018

This package does not generate any message so it doesnt need to depend on the generators, instead it should link against the libraries that provide the symbols it uses (in this case rosidl_typesupport_cpp)

Connects to ros2/demos#264

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jul 3, 2018
@mikaelarguedas
Copy link
Copy Markdown
Member Author

CI for this at ros2/demos#264 (comment)

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 3, 2018
@mikaelarguedas mikaelarguedas self-assigned this Jul 4, 2018
@mikaelarguedas mikaelarguedas merged commit 4507d7a into master Jul 5, 2018
@mikaelarguedas mikaelarguedas deleted the remove_unused_deps branch July 5, 2018 20:01
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jul 5, 2018
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants