Conversation
Contributor
Author
|
Keeping In progress label, while CI runs
|
dirk-thomas
approved these changes
Jun 6, 2018
| rclcpp::Parameter | ||
| get_parameter(const std::string & name) const = 0; | ||
|
|
||
| /// Return the description of one parameter given a name. |
mikaelarguedas
approved these changes
Jun 6, 2018
Contributor
Author
|
Assuming 886cf2a won't break CI since it only shortens comments, and merging. |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Fail fast on invalid ROS arguments. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Address peer review comments. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Fix warning on Windows. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* add storage_config_uri Signed-off-by: Karsten Knese <karsten@openrobotics.org> * linters and tests Signed-off-by: Karsten Knese <karsten@openrobotics.org> * move storage options to rosbag2_storage Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * use storage options to open storage backends Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * add rosbag2_py to metapackage Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters that are queried but don't exist on the node should return a value with type NOT_SET to comply with the service definition in
rcl_interfaces.This PR only changes the behavior of the
get_parametersservice. The C++ API doesn't have the same problem (it returns both the name and the value of the parameter), so this PR adds documentation to it instead.Fixes #490
connects to #490